From: Kevin Day <Kevin@kevux.org>
Date: Sat, 28 Jun 2025 03:22:35 +0000 (-0500)
Subject: Regression: The console should return F_complete_not when incomplete.
X-Git-Tag: 0.7.2~5
X-Git-Url: https://www.git.kevux.org/?a=commitdiff_plain;h=0528da1f04759ff677550ea9c9f2a7f338daf5a7;p=fll

Regression: The console should return F_complete_not when incomplete.

This is a regression in the commit 9d9f95d9f879ea4ca3477233f9ceb25251ba99f5.

The check to see if the needs array is still used on exit ended up moving up inside a nested function.

This results in situations where the check gets missed.

Relocate the check outside of the conditional blocks (but still inside the F_process conditional block).
---

diff --git a/level_0/f_console/c/console.c b/level_0/f_console/c/console.c
index b64dc7c..2461795 100644
--- a/level_0/f_console/c/console.c
+++ b/level_0/f_console/c/console.c
@@ -753,12 +753,12 @@ extern "C" {
 
             parameters->remaining.array[parameters->remaining.used++] = process.location;
           } // for
-
-          if (F_status_is_error_not(state->status)) {
-            state->status = process.needs.used ? F_complete_not : F_okay;
-          }
         }
       }
+
+      if (F_status_is_error_not(state->status)) {
+        state->status = process.needs.used ? F_complete_not : F_okay;
+      }
     }
 
     f_memory_array_resize(0, sizeof(f_number_unsigned_t), (void **) &process.needs.array, &process.needs.used, &process.needs.size);