]> Kevux Git Server - rit/commitdiff
strbuf_readlink: use ssize_t
authorJeff King <peff@peff.net>
Tue, 24 Jul 2018 10:51:25 +0000 (06:51 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 24 Jul 2018 17:19:29 +0000 (10:19 -0700)
The return type of readlink() is ssize_t, not int. This
probably doesn't matter in practice, as it would require a
2GB symlink destination, but it doesn't hurt to be careful.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
strbuf.c

index 6ff1f80..db9069c 100644 (file)
--- a/strbuf.c
+++ b/strbuf.c
@@ -469,7 +469,7 @@ int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint)
                hint = 32;
 
        while (hint < STRBUF_MAXLINK) {
-               int len;
+               ssize_t len;
 
                strbuf_grow(sb, hint);
                len = readlink(path, sb->buf, hint);