]> Kevux Git Server - rit/commitdiff
bundle: remove ignored & undocumented "--verbose" flag
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 23 Sep 2021 16:48:22 +0000 (18:48 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 23 Sep 2021 22:03:48 +0000 (15:03 -0700)
In 73c3253d75e (bundle: framework for options before bundle file,
2019-11-10) the "git bundle" command was refactored to use
parse_options(). In that refactoring it started understanding the
"--verbose" flag before the subcommand, e.g.:

    git bundle --verbose verify --quiet

However, nothing ever did anything with this "verbose" variable, and
the change wasn't documented. It appears to have been something that
escaped the lab, and wasn't flagged by reviewers at the time. Let's
just remove it.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bundle.c

index 053a51b..5f31354 100644 (file)
@@ -39,8 +39,6 @@ static const char * const builtin_bundle_unbundle_usage[] = {
   NULL
 };
 
-static int verbose;
-
 static int parse_options_cmd_bundle(int argc,
                const char **argv,
                const char* prefix,
@@ -188,7 +186,6 @@ cleanup:
 int cmd_bundle(int argc, const char **argv, const char *prefix)
 {
        struct option options[] = {
-               OPT__VERBOSE(&verbose, N_("be verbose; must be placed before a subcommand")),
                OPT_END()
        };
        int result;