bundle-uri: send debug output to given FILE * stream

d796cedb (bundle-uri: unit test "key=value" parsing, 2022-10-12)
introduced the print_bundle_list() function, which takes a "FILE
*fp" to write the output to.  Later with c93c3d2f (bundle-uri:
parse bundle.heuristic=creationToken, 2023-01-31) the function
started showing additional information, which is always written
to the standard output stream.

It does not look like a deliberate decision to do so, and it
does not hurt, as all callers of the function passes stdout to
it.

We could change the function not to take fp and always write to
the standard output to simplify, but let's use the FILE *fp
provided by the caller consistently to write out output.

Signed-off-by: Jan Mazur <mzr@meta.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/bundle-uri.c b/bundle-uri.c
index 8a3c39c..72e70c5 100644 (file)
--- a/bundle-uri.c
+++ b/bundle-uri.c
@@ -115,7 +115,7 @@ void print_bundle_list(FILE *fp, struct bundle_list *list)
                int i;
                for (i = 0; i < BUNDLE_HEURISTIC__COUNT; i++) {
                        if (heuristics[i].heuristic == list->heuristic) {
-                               printf("\theuristic = %s\n",
+                               fprintf(fp, "\theuristic = %s\n",
                                       heuristics[list->heuristic].name);
                                break;
                        }