receive-pack: lowercase error messages

Documentation/CodingGuidelines says “do not end error messages with a
full stop” and “do not capitalize the first word”.  Clean up existing
messages, some of which we will be touching in later steps in the
series, that deviate from these rules in this file, as a preparation for
the main part of the topic.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 49b846d..ddda27c 100644 (file)
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -175,7 +175,7 @@ static int receive_pack_config(const char *var, const char *value, void *cb)
                        strbuf_addf(&fsck_msg_types, "%c%s=%s",
                                fsck_msg_types.len ? ',' : '=', var, value);
                else
-                       warning("Skipping unknown msg id '%s'", var);
+                       warning("skipping unknown msg id '%s'", var);
                return 0;
        }
 
@@ -1589,9 +1589,9 @@ static const char *update(struct command *cmd, struct shallow_info *si)
                if (!parse_object(the_repository, old_oid)) {
                        old_oid = NULL;
                        if (ref_exists(name)) {
-                               rp_warning("Allowing deletion of corrupt ref.");
+                               rp_warning("allowing deletion of corrupt ref");
                        } else {
-                               rp_warning("Deleting a non-existent ref.");
+                               rp_warning("deleting a non-existent ref");
                                cmd->did_not_exist = 1;
                        }
                }
@@ -2490,9 +2490,9 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
        argc = parse_options(argc, argv, prefix, options, receive_pack_usage, 0);
 
        if (argc > 1)
-               usage_msg_opt(_("Too many arguments."), receive_pack_usage, options);
+               usage_msg_opt(_("too many arguments"), receive_pack_usage, options);
        if (argc == 0)
-               usage_msg_opt(_("You must specify a directory."), receive_pack_usage, options);
+               usage_msg_opt(_("you must specify a directory"), receive_pack_usage, options);
 
        service_dir = argv[0];
 

diff --git a/t/t5504-fetch-receive-strict.sh b/t/t5504-fetch-receive-strict.sh
index 6e5a9c2..b0b795a 100755 (executable)
--- a/t/t5504-fetch-receive-strict.sh
+++ b/t/t5504-fetch-receive-strict.sh
@@ -292,7 +292,7 @@ test_expect_success 'push with receive.fsck.missingEmail=warn' '
                receive.fsck.missingEmail warn &&
        git push --porcelain dst bogus >act 2>&1 &&
        grep "missingEmail" act &&
-       test_i18ngrep "Skipping unknown msg id.*whatever" act &&
+       test_i18ngrep "skipping unknown msg id.*whatever" act &&
        git --git-dir=dst/.git branch -D bogus &&
        git --git-dir=dst/.git config --add \
                receive.fsck.missingEmail ignore &&