reftable/record: stop using `COPY_ARRAY()`

Drop our use of `COPY_ARRAY()`, replacing it with an open-coded variant
thereof. This is done to reduce our dependency on the Git library.

While at it, guard the whole array copy logic so that we only copy it in
case there actually is anything to be copied. Otherwise, we may end up
trying to allocate a zero-sized array, which will return a NULL pointer
and thus cause us to return an `REFTABLE_OUT_OF_MEMORY_ERROR`.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/reftable/record.c b/reftable/record.c
index 8919df8..2c0cc32 100644 (file)
--- a/reftable/record.c
+++ b/reftable/record.c
@@ -504,11 +504,17 @@ static int reftable_obj_record_copy_from(void *rec, const void *src_rec,
        if (src->hash_prefix_len)
                memcpy(obj->hash_prefix, src->hash_prefix, obj->hash_prefix_len);
 
-       REFTABLE_ALLOC_ARRAY(obj->offsets, src->offset_len);
-       if (!obj->offsets)
-               return REFTABLE_OUT_OF_MEMORY_ERROR;
-       obj->offset_len = src->offset_len;
-       COPY_ARRAY(obj->offsets, src->offsets, src->offset_len);
+       if (src->offset_len) {
+               if (sizeof(*src->offsets) > SIZE_MAX / src->offset_len)
+                       return REFTABLE_OUT_OF_MEMORY_ERROR;
+
+               REFTABLE_ALLOC_ARRAY(obj->offsets, src->offset_len);
+               if (!obj->offsets)
+                       return REFTABLE_OUT_OF_MEMORY_ERROR;
+
+               memcpy(obj->offsets, src->offsets, sizeof(*src->offsets) * src->offset_len);
+               obj->offset_len = src->offset_len;
+       }
 
        return 0;
 }