Regression: The console should return F_complete_not when incomplete.

This is a regression in the commit 9d9f95d9f879ea4ca3477233f9ceb25251ba99f5.

The check to see if the needs array is still used on exit ended up moving up inside a nested function.

This results in situations where the check gets missed.

Relocate the check outside of the conditional blocks (but still inside the F_process conditional block).

diff --git a/level_0/f_console/c/console.c b/level_0/f_console/c/console.c
index b64dc7ce572c2f959b16c36d6e37b5eb47696b89..246179566d247cbaab49b0ebf1d94e627d94ed59 100644 (file)
--- a/level_0/f_console/c/console.c
+++ b/level_0/f_console/c/console.c
@@ -753,12 +753,12 @@ extern "C" {
 
             parameters->remaining.array[parameters->remaining.used++] = process.location;
           } // for
-
-          if (F_status_is_error_not(state->status)) {
-            state->status = process.needs.used ? F_complete_not : F_okay;
-          }
         }
       }
+
+      if (F_status_is_error_not(state->status)) {
+        state->status = process.needs.used ? F_complete_not : F_okay;
+      }
     }
 
     f_memory_array_resize(0, sizeof(f_number_unsigned_t), (void **) &process.needs.array, &process.needs.used, &process.needs.size);