]> Kevux Git Server - rit/commit
object-file-convert: stop depending on `the_repository`
authorPatrick Steinhardt <ps@pks.im>
Mon, 10 Mar 2025 07:13:27 +0000 (08:13 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 10 Mar 2025 20:16:19 +0000 (13:16 -0700)
commitf6e174b2d8b83c17376b163fc4f8062fa3140a04
tree70027c3b1bb65e0f6002aa560449242a37d84b51
parent1a6768d1dd6d92b34f25507091ff0775371e19cb
object-file-convert: stop depending on `the_repository`

There are multiple sites in "object-file-convert.c" where we use the
global `the_repository` variable, either explicitly or implicitly by
using `the_hash_algo`. All of these callsites are transitively called
from `convert_object_file()`, which indeed has no repo as input.

Refactor the function so that it receives a repository as a parameter
and pass it through to all internal functions to get rid of the
dependency. Remove the `USE_THE_REPOSITORY_VARIABLE` define.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/tag.c
commit.c
object-file-convert.c
object-file-convert.h
object-file.c