]> Kevux Git Server - rit/commit
upload-pack: remove superfluous sigchain_pop() call
authorRené Scharfe <l.s.r@web.de>
Tue, 11 Aug 2020 17:15:03 +0000 (19:15 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 11 Aug 2020 21:01:18 +0000 (14:01 -0700)
commite767963ab6a542649c91f79fb686c58574b1ee86
tree79cae31cfb2a3d691d9627ff3c07f3ce337a375b
parent47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc
upload-pack: remove superfluous sigchain_pop() call

2997178ee6 (upload-pack: split check_unreachable() in two, prep for
get_reachable_list(), 2016-06-12) moved most code of has_unreachable()
into the new function do_reachable_revlist().  The latter takes care to
ignore SIGPIPE during its operations, and restores the original signal
handler before returning.

However, a sigchain_pop(SIGPIPE) call remained in the error handling
code of has_unreachable(), which does nothing because the stack is
empty after do_reachable_revlist() cleaned up after itself.  Remove it.

Signed-off-by: René Scharfe <l.s.r@web.de>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
upload-pack.c