]> Kevux Git Server - rit/commit
git-gui: use [is_Windows], not bad _shellpath
authorMark Levedahl <mlevedahl@gmail.com>
Wed, 2 Apr 2025 15:23:03 +0000 (11:23 -0400)
committerTaylor Blau <me@ttaylorr.com>
Fri, 23 May 2025 21:04:23 +0000 (17:04 -0400)
commitc5c32781c99bfa9d8b7c51b4a1ad66a9fa1e6bfe
tree6fb93b93ac55978f16acfa9dbde319caa761bf77
parent37b9230226db2a3a81df2e92a44ea655076cd0c4
git-gui: use [is_Windows], not bad _shellpath

Commit 7d076d56757c (git-gui: handle shell script text filters when
loading for blame, 2011-12-09) added open_cmd_pipe, with special
handling for Windows detected by seeing that _shellpath does not
point to an executable shell. That is bad practice, and is broken by
the next commit that assures _shellpath is valid on all platforms.

Fix this by using [is_Windows] as done for all Windows specific code.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
git-gui.sh