]> Kevux Git Server - rit/commit
pack-bitmap-write.c: don't return without stop_progress()
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 3 Feb 2022 21:40:19 +0000 (22:40 +0100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 3 Feb 2022 23:40:00 +0000 (15:40 -0800)
commitb3118a56f99ca0ec872b84dc760a0dc778f3890e
tree3c03872d6c213c3b2e29b37e3c37c86f19dac97d
parent74900a6b3513e0908b1d16df7855e9d478b20b91
pack-bitmap-write.c: don't return without stop_progress()

Fix a bug that's been here since 7cc8f971085 (pack-objects: implement
bitmap writing, 2013-12-21), we did not call stop_progress() if we
reached the early exit in this function.

We could call stop_progress() before we return, but better yet is to
defer calling start_progress() until we need it. For now this only
matters in practice because we'd previously omit the "region_leave"
for the progress trace2 event.

Suggested-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pack-bitmap-write.c