]> Kevux Git Server - rit/commit
strbuf_attach: fix call sites to pass correct alloc
authorVaidas Pilkauskas <vaidas.pilkauskas@shopify.com>
Tue, 17 Mar 2026 13:00:34 +0000 (13:00 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 17 Mar 2026 16:14:19 +0000 (09:14 -0700)
commita4fddb01c5bd0ecbd5e297ee571ad29ca62bf940
treef6db6091b7ab32c3c2eadcbb8ee43bb31bf4892c
parentbc6a6cf5eedb19b1b1da92ed2761ff9b1c7da627
strbuf_attach: fix call sites to pass correct alloc

strbuf_attach(sb, buf, len, alloc) requires alloc > len (the buffer
must have at least len+1 bytes to hold the NUL). Several call sites
passed alloc == len, relying on strbuf_grow(sb, 0) inside strbuf_attach
to reallocate. Fix these in mailinfo, am, refs/files-backend,
fast-import, and trailer by passing len+1 when the buffer is a
NUL-terminated string (or from strbuf_detach).

Signed-off-by: Vaidas Pilkauskas <vaidas.pilkauskas@shopify.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/am.c
builtin/fast-import.c
mailinfo.c
refs/files-backend.c
trailer.c