]> Kevux Git Server - rit/commit
midx: introduce `midx_get_checksum_hex()`
authorTaylor Blau <me@ttaylorr.com>
Tue, 24 Feb 2026 18:59:44 +0000 (13:59 -0500)
committerJunio C Hamano <gitster@pobox.com>
Tue, 24 Feb 2026 19:16:32 +0000 (11:16 -0800)
commit6e86f679248580bec5c105b37217862f3022b504
tree75e780d855857c2cfaf7e265ef0200b7d952fe0f
parentde811c26bb97ac324b60883ae4f4db84a83be2f1
midx: introduce `midx_get_checksum_hex()`

When trying to print out, say, the hexadecimal representation of a
MIDX's hash, our code will do something like:

    hash_to_hex_algop(midx_get_checksum_hash(m),
                      m->source->odb->repo->hash_algo);

, which is both cumbersome and repetitive. In fact, all but a handful of
callers to `midx_get_checksum_hash()` do exactly the above. Reduce the
repetitive nature of calling `midx_get_checksum_hash()` by having it
return a pointer into a static buffer containing the above result.

For the handful of callers that do need to compare the raw bytes and
don't want to deal with an encoded copy (e.g., because they are passing
it to hasheq() or similar), they may still rely on
`midx_get_checksum_hash()` which returns the raw bytes.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
midx-write.c
midx.c
midx.h
pack-bitmap.c
t/helper/test-read-midx.c