]> Kevux Git Server - rit/commit
parse_object(): drop extra "has" check before checking object type
authorJeff King <peff@peff.net>
Thu, 17 Nov 2022 22:37:58 +0000 (17:37 -0500)
committerTaylor Blau <me@ttaylorr.com>
Fri, 18 Nov 2022 18:59:31 +0000 (13:59 -0500)
commit04fb96219abc0cbe46ba084997dc9066de3ac889
treef44b90e3c351931cf5991f05ca335b1a1a66521a
parenteea7033409a0ed713c78437fc76486983d211e25
parse_object(): drop extra "has" check before checking object type

When parsing an object of unknown type, we check to see if it's a blob,
so we can use our streaming code path. This uses oid_object_info() to
check the type, but before doing so we call repo_has_object_file(). This
latter is pointless, as oid_object_info() will already fail if the
object is missing. Checking it ahead of time just complicates the code
and is a waste of resources (albeit small).

Let's drop the redundant check.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
object.c